Very nice! I was chasing this one for a while already. The patch works for
me.

-- Robbert

> -----Original Message-----
> From: Meloun Michal [mailto:[EMAIL PROTECTED]
> Sent: Monday, February 02, 2004 4:09 PM
> To: [EMAIL PROTECTED]
> Subject: [Ntop-dev] [BUG + PATCH] Self resetting domain statistic
> 
> 
> I found bug in util.c:fillDomainName() routine ->
> if hostname is already resolved (and flag 
> FLAG_THE_DOMAIN_HAS_BEEN_COMPUTED is set),
> then any next call into fillDomainName() clears previously 
> resolved data.
> This patch fixes "self reset" issue in "IP Summary" -> 
> "Domain" but also 
> affect near all IP related pages - compare number of resolved 
> addresses before and after patch.
> 
> Michal Meloun
> 
> --- util.c.orig Mon Feb  2 15:37:11 2004
> +++ util.c      Mon Feb  2 15:37:57 2004
> @@ -2899,8 +2899,9 @@
>    u_int i;
>    char *ip2cc;
> 
> -  if(theDomainHasBeenComputed(el)
> -     || (el->hostSymIpAddress    == NULL)
> +  if(theDomainHasBeenComputed(el))
> +    return;
> +  if((el->hostSymIpAddress    == NULL)
>       || (el->hostSymIpAddress[0] == '\0')) {
>      el->fullDomainName = strdup("");
>      return;
> 
> _______________________________________________
> Ntop-dev mailing list
> [EMAIL PROTECTED]
> http://listgateway.unipi.it/mailman/listinfo/ntop-dev
> 


_______________________________________________
Ntop-dev mailing list
[EMAIL PROTECTED]
http://listgateway.unipi.it/mailman/listinfo/ntop-dev

Reply via email to