I’m against this change, because it:

   - Is inconsistent with the builtin random.shuffle
   - Makes it easy to fall into the trap of assuming that np.random.shuffle
   does not mutate it’s input

Eric
​

On Thu, 12 Apr 2018 at 10:37 Joseph Fox-Rabinovitz <jfoxrabinov...@gmail.com>
wrote:

> Would it break backwards compatibility to add the input as a return value
> to np.random.shuffle? I doubt anyone out there is relying on the None
> return value.
>
> The change is trivial, and allows shuffling a new array in one line
> instead of two:
>
>     x = np.random.shuffle(np.array(some_junk))
>
> I've implemented the change in PR#10893.
>
> Regards,
>
> - Joe
> _______________________________________________
> NumPy-Discussion mailing list
> NumPy-Discussion@python.org
> https://mail.python.org/mailman/listinfo/numpy-discussion
>
_______________________________________________
NumPy-Discussion mailing list
NumPy-Discussion@python.org
https://mail.python.org/mailman/listinfo/numpy-discussion

Reply via email to