On Dec 21, 2007 10:04 AM, David Cournapeau <[EMAIL PROTECTED]> wrote: > On Dec 20, 2007 10:29 AM, Travis E. Oliphant <[EMAIL PROTECTED]> wrote:
> > How did you get around using #ifdef etc? This concerns me to just > > change it, unless I'm convinced there is no problem. > I don't get around them, I just do not use them inside generated > files. For example, NPY_ALLOW_THREADS is defined in ndarrayobject.h, > now, depending on some values defined in the config headers. Having > #ifdef inside generated files is a bit against the spirit of config > headers, and it makes also more complicated to generate them through > standard tools (neither scons nor autoheader supports this, for > example). Travis, did you get any chance to look at it ? If the goal is to merge the changes needed for scons support for 1.0.5, I would prefer having a few days between the merge and the release to take care about problems cheers, David _______________________________________________ Numpy-discussion mailing list [email protected] http://projects.scipy.org/mailman/listinfo/numpy-discussion
