On Mar 26, 2010, at 8:32 PM, Arnaud Quette wrote:
2010/3/22 Charles Lepple <[email protected]>
On Mar 19, 2010, at 1:21 PM, Arnaud Quette wrote:
[...]
At r2403, the code does not force the creation of a ChangeLog if a
user simply checks out the source, then runs autoreconf, configure and
make. I am wondering if we should remove the "|| echo" portion, and
simply add a "touch ChangeLog" on the buildslaves that don't have
svn2cl (and wouldn't need it, since they are not all distributing
tarball snapshots).
nice job.
I'm in favor of keeping the failure warning msg, while touching
ChangeLog.
note that I haven't yet had a chance to test it though.
Hmm, maybe I misinterpreted "keeping the failure warning message".
I was not quite clear indeed!
echo "svn2cl failed to generate the ChangeLog. See http://trac.networkupstools.org/projects/nut/timeline
" > ChangeLog
OK, I just committed that again.
putting the above msg into ChangeLog is fine. also echo'ing it would
be a plus.
The message should be visible from the 'make' output.
the cherry for maintainability would be an "UP_TO_VERSION" param
that get the revision number, using something like:
svn log -v -q --stop-on-copy svn://svn.debian.org/nut/tags/v2.4.3
We can run that manually, if we really need to adjust the start point
of the ChangeLog. Alioth's SVN service is not particularly fast, so if
the UP_TO_VERSION hasn't changed, I don't think we want to be polling
for it every time we build.
If this builds properly, I will merge it into the trunk.
--
Charles Lepple
clep...@gmail
_______________________________________________
Nut-upsdev mailing list
[email protected]
http://lists.alioth.debian.org/mailman/listinfo/nut-upsdev
