Citeren rasengan rootish <r...@relay.ppgk.com.pl>:

So basically what you have in mind is putting such checks in main.c's loop somewhere after upsdrv_updateinfo() call, and then updating ups.status ?

Yes.

That would also warrant adding options enabling such functionality (separately for charge and runtime), as not everyone might want it.

No. If both 'battery.charge' and 'battery.charge.low' are present, there is no need to make this configurable. A UPS that supports them out of the box, will already set the LB flag (so there is no possibility to change that). If you don't want this added functionality, don't set a default value in 'ups.conf' (similar for runtime).

In case you happen to have a UPS that does report both 'battery.charge' and 'battery.charge.low' but for some mysterious reason doesn't use that to set the LB flag, you can always use 'override.battery.charge.low=0' to disable it.

I'll redo the patches with the new approach.

Thanks.

Best regards, Arjen
--
Please keep list traffic on the list (off-list replies will be rejected)


_______________________________________________
Nut-upsdev mailing list
Nut-upsdev@lists.alioth.debian.org
http://lists.alioth.debian.org/mailman/listinfo/nut-upsdev

Reply via email to