[
https://issues.apache.org/jira/browse/NUTCH-559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12530382
]
Doğacan Güney commented on NUTCH-559:
-------------------------------------
Susam, thanks for turning this into a patch.
Patch is looking good, but I think it needs to go through a couple of revisions
before it is ready. Some comments:
* Is it possible to extend authentication to work for more than one host? I am
thinking something like this:
<property>
<name>http.auth</name>
<value>{host}:{realm}:{username}:{passwd},...</value>
</property>
So that in a single fetch, fetcher can authenticate across different domains.
* You don't have to call configureClient on every getResponse. I understand
that you are doing this for authentication reasons. But you can just move
configureClient to where it used to be and add a new method there for
authentication.
* Also, you are removing too much from configureClient (for example, headers).
Unless there is a reason that for removing the code, it should stay there.
* In HttpResponse, you removed all the cookie policy related code. Why?
* Also in HttpResponse, you can use calculateTryToRead and other response
reading code instead of writing your own.
> NTLM, Basic and Digest Authentication schemes for web/proxy server
> ------------------------------------------------------------------
>
> Key: NUTCH-559
> URL: https://issues.apache.org/jira/browse/NUTCH-559
> Project: Nutch
> Issue Type: Improvement
> Components: fetcher
> Affects Versions: 1.0.0
> Reporter: Susam Pal
> Attachments: NUTCH-559v0.1.patch
>
>
> Added basic, digest and NTLM authentication schemes to protocol-httpclient.
> The authentication schemes can be configured for proxy server as well as web
> servers of a domain. HTTP authentication can take place over HTTP/1.0,
> HTTP/1.1 and HTTPS.
> The authentication guide can be found here:
> [http://wiki.apache.org/nutch/HttpAuthenticationSchemes].
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
