[ 
https://issues.apache.org/jira/browse/NUTCH-559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12539131
 ] 

Doğacan Güney commented on NUTCH-559:
-------------------------------------

Hi Susam,

Your last patch looks great!

I have one minor nit: I think it would be better to move http.auth.* properties 
to httpclient-auth.xml file so that all authentication configuration is in one 
place
(for example, we can add a defaultscope or whatever tag to define defauflt 
username/password/etc). What do you think?

Also, I am wondering if we can have some test cases for this patch. Is it 
possible to start, say, jetty during a junit test and test authentication?

I am going to test this patch within this week and return with further comments.

> NTLM, Basic and Digest Authentication schemes for web/proxy server
> ------------------------------------------------------------------
>
>                 Key: NUTCH-559
>                 URL: https://issues.apache.org/jira/browse/NUTCH-559
>             Project: Nutch
>          Issue Type: Improvement
>          Components: fetcher
>    Affects Versions: 1.0.0
>            Reporter: Susam Pal
>         Attachments: NUTCH-559v0.1.patch, NUTCH-559v0.2.patch, 
> NUTCH-559v0.3.patch
>
>
> Added basic, digest and NTLM authentication schemes to protocol-httpclient. 
> The authentication schemes can be configured for proxy server as well as web 
> servers of a domain. HTTP authentication can take place over HTTP/1.0, 
> HTTP/1.1 and HTTPS.
> The authentication guide can be found here: 
> [http://wiki.apache.org/nutch/HttpAuthenticationSchemes].

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to