Well, you could always 'freeze' it, just create a decorator for it. So,
create a new Configuration (call it ImmutableConfiguration) store the
original configuration object in it, and delegate the methods appropriately.
Wouldn't that work?
On 6/8/07, Doğacan Güney <[EMAIL PROTECTED]> wrote:
On 5/31/07, Nicolás Lichtmaier <[EMAIL PROTECTED]> wrote:
>
> > Actually thinking a bit further into this, I kind of agree with you. I
> > initially thought that the best approach would be to change
> > PluginRepository.get(Configuration) to PluginRepository.get() where
> > get() just creates a configuration internally and initializes itself
> > with it. But then we wouldn't be passing JobConf to PluginRepository
> > but PluginRepository would do something like a
> > NutchConfiguration.create(), which is probably wrong.
> >
> > So, all in all, I've come to believe that my (and Nicolas') patch is a
> > not-so-bad way of fixing this. It allows us to pass JobConf to
> > PluginRepository and stops creating new PluginRepository-s again and
> > again...
> >
> > What do you think?
>
> IMO a better way would be to add a proper equals() method to Hadoop's
> Configuration object (and hashcode) that would call
> getProps().equals(o.getProps()). So that you could use them as keys...
> Every class which is a map from keys to values has "equals & hashcode"
> (Properties, HashMap, etc.).
>
> Another nice thing would be to be able to "freeze" a configuration
> object, preventing anyone from modifying it.
>
>
I found that there is already an issue for this problem - NUTCH-356. I
will update it with most recent discussions.
--
Doğacan Güney
--
"Conscious decisions by conscious minds are what make reality real"
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
Nutch-developers mailing list
Nutch-developers@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nutch-developers
