> > > diff --git a/drivers/cxl/core/memdev.c b/drivers/cxl/core/memdev.c
> > > index df2ba87238c2..d9ade5b92330 100644
> > > --- a/drivers/cxl/core/memdev.c
> > > +++ b/drivers/cxl/core/memdev.c
> > > @@ -134,6 +134,37 @@ static const struct device_type cxl_memdev_type = {
> > > .groups = cxl_memdev_attribute_groups,
> > > };
> > >
> > > +/**
> > > + * set_exclusive_cxl_commands() - atomically disable user cxl commands
> > > + * @cxlm: cxl_mem instance to modify
> > > + * @cmds: bitmap of commands to mark exclusive
> > > + *
> > > + * Flush the ioctl path and disable future execution of commands with
> > > + * the command ids set in @cmds.
> >
> > It's not obvious this function is doing that 'flush', Perhaps consider
> > rewording?
>
> Changed it to:
>
> "Grab the cxl_memdev_rwsem in write mode to flush in-flight
> invocations of the ioctl path and then disable future execution of
> commands with the command ids set in @cmds."
Great
>
> >
> > > + */
> > > +void set_exclusive_cxl_commands(struct cxl_mem *cxlm, unsigned long
> > > *cmds)
> > > +{
> > > + down_write(&cxl_memdev_rwsem);
> > > + bitmap_or(cxlm->exclusive_cmds, cxlm->exclusive_cmds, cmds,
> > > + CXL_MEM_COMMAND_ID_MAX);
> > > + up_write(&cxl_memdev_rwsem);
> > > +}
> > > +EXPORT_SYMBOL_GPL(set_exclusive_cxl_commands);
...
> > > diff --git a/drivers/cxl/pmem.c b/drivers/cxl/pmem.c
> > > index 9652c3ee41e7..a972af7a6e0b 100644
> > > --- a/drivers/cxl/pmem.c
> > > +++ b/drivers/cxl/pmem.c
> > > @@ -16,10 +16,7 @@
> > > */
> > > static struct workqueue_struct *cxl_pmem_wq;
> > >
...
> >
> > > +
> > > + nvdimm_delete(nvdimm);
> > > + clear_exclusive_cxl_commands(cxlm, exclusive_cmds);
> > > +}
> > > +
> > > static int cxl_nvdimm_probe(struct device *dev)
> > > {
> > > struct cxl_nvdimm *cxl_nvd = to_cxl_nvdimm(dev);
> > > + struct cxl_memdev *cxlmd = cxl_nvd->cxlmd;
> > > + struct cxl_mem *cxlm = cxlmd->cxlm;
> >
> > Again, clxmd not used so could save a line of code
> > without loosing anything (unless it get used in a later patch of
> > course!)
>
> It is used... to grab cxlm, but it's an arbitrary style preference to
> avoid de-reference chains longer than one. However, since I'm only
> doing it once now perhaps you'll grant me this indulgence?
>
This one was a 'could'. Entirely up to you whether you do :)
Jonathan
