On Thu, Nov 11, 2021 at 12:45 PM Vishal Verma <[email protected]> wrote: > > Add JSON output for fields from the 'GET_HEALTH_INFO' mailbox command > to memory device listings. > > Cc: Dan Williams <[email protected]> > Signed-off-by: Vishal Verma <[email protected]> > --- > Documentation/cxl/cxl-list.txt | 4 + > util/json.h | 1 + > cxl/list.c | 5 + > util/json.c | 179 +++++++++++++++++++++++++++++++++ > 4 files changed, 189 insertions(+) > > diff --git a/Documentation/cxl/cxl-list.txt b/Documentation/cxl/cxl-list.txt > index bd377b3..dc86651 100644 > --- a/Documentation/cxl/cxl-list.txt > +++ b/Documentation/cxl/cxl-list.txt > @@ -53,6 +53,10 @@ OPTIONS > --idle:: > Include idle (not enabled / zero-sized) devices in the listing > > +-H:: > +--health:: > + Include health information in the memdev listing
Let's include a sample listing here in the man page, like the following, so that people can get an idea ahead of time about the key names and value types in the payload. Other than that you can add: Reviewed-by: Dan Williams <[email protected]> { "memdev":"mem7", "pmem_size":268435456, "ram_size":268435456, "health":{ "maintenance_needed":true, "performance_degraded":true, "hw_replacement_needed":true, "media_normal":false, "media_not_ready":false, "media_persistence_lost":false, "media_data_lost":true, "media_powerloss_persistence_loss":false, "media_shutdown_persistence_loss":false, "media_persistence_loss_imminent":false, "media_powerloss_data_loss":false, "media_shutdown_data_loss":false, "media_data_loss_imminent":false, "ext_life_used":"normal", "ext_temperature":"critical", "ext_corrected_volatile":"warning", "ext_corrected_persistent":"normal", "life_used_percent":15, "temperature":25, "dirty_shutdowns":10, "volatile_errors":20, "pmem_errors":30 }
