On Thu, 2021-09-16 at 15:58 -0700, Dan Williams wrote: > On Tue, Aug 31, 2021 at 2:05 AM Vishal Verma <[email protected]> wrote: > > > > Add support similar to ndctl and libndctl for parsing config files. This > > allows storing a config file path/list in the daxctl_ctx, and adds APIs > > for setting and retrieving it. > > > > Cc: QI Fuli <[email protected]> > > Signed-off-by: Vishal Verma <[email protected]> > > --- > > daxctl/lib/libdaxctl.c | 37 +++++++++++++++++++++++++++++++++++++ > > daxctl/libdaxctl.h | 2 ++ > > daxctl/Makefile.am | 1 + > > daxctl/lib/Makefile.am | 4 ++++ > > daxctl/lib/libdaxctl.sym | 2 ++ > > 5 files changed, 46 insertions(+) > > [snip] > > > > diff --git a/daxctl/Makefile.am b/daxctl/Makefile.am > > index 9b1313a..a9845a0 100644 > > --- a/daxctl/Makefile.am > > +++ b/daxctl/Makefile.am > > @@ -10,6 +10,7 @@ config.h: $(srcdir)/Makefile.am > > "$(daxctl_modprobe_datadir)/$(daxctl_modprobe_data)"' >>$@ > > && \ > > echo '#define DAXCTL_MODPROBE_INSTALL \ > > "$(sysconfdir)/modprobe.d/$(daxctl_modprobe_data)"' >>$@ > > + $(AM_V_GEN) echo '#define DAXCTL_CONF_DIR "$(ndctl_confdir)"' >>$@ > > This gets back to my namespace question about collisions between > daxctl, ndctl, and cxl-cli conf snippets. I think they should each get > their own directory in /etc, then we don't need to encode any prefixes > into section names. What do you think?
Yep splitting config directories sounds cleaner - I'll change this.
