On Thu, 2021-09-16 at 16:54 -0700, Dan Williams wrote: > On Tue, Aug 31, 2021 at 2:05 AM Vishal Verma <[email protected]> wrote: > > > > Add a new config query type called CONFIG_SEARCH_SECTION, which searches > > all loaded config files based on a query criteria of: specified section > > name, specified key/value pair within that section, and can return other > > key/values from the section that matched the search criteria. > > > > This allows for multiple named subsections, where a subsection name is > > of the type: '[section subsection]'. > > Presumably in the future this could be used to search by subsection as > well, but for now daxctl does not need that and the subsection is > essentially a comment?
Correct. > > Perhaps that should be called out in a sample / comment only > daxctl.conf file that gets installed by default. Where it clarifies > that everything after the first whitespace in a section name is > treated as a subsection. Hm the man page does say: Note that the 'subsection name' can be arbitrary, and is only used to identify a specific config section. It does not have to match the 'device name' (e.g. 'dax0.0' etc). I didn't include a sample/comment-only config file - I figured the man page snippets should be sufficient for anyone who wants to write one - but I can add something if it's useful. > > This looks good to me.
