On Wed, Dec 08, 2021 at 04:48:46PM -0800, Darrick J. Wong wrote:
> On Wed, Dec 08, 2021 at 10:12:03AM +0100, Christoph Hellwig wrote:
> > bytes also hold the return value from iomap_write_end, which can contain
> > a negative error value. As bytes is always less than the page size even
> > the signed type can hold the entire possible range.
> >
> > Fixes: c6f40468657d ("fsdax: decouple zeroing from the iomap buffered I/O
> > code")
...waitaminute, ^^^^^^ in what tree is this commit? Did Linus merge
the dax decoupling series into upstream without telling me?
/me checks... no?
Though I searched for it on gitweb and came up with this bizarre plot
twist:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=c6f40468657d16e4010ef84bf32a761feb3469ea
(Is this the same as that github thing a few months ago where
everybody's commits get deduplicated into the same realm and hence
anyone can make trick the frontend into sort of making it look like
their rando commits end up in Linus' tree? Or did it get merged and
push -f reverted?)
Ok, so ... I don't know what I'm supposed to apply this to? Is this
something that should go in Christoph's development branch?
<confused, going to run away now>
On the plus side, that means I /can/ go test-merge willy's iomap folios
for 5.17 stuff tonight.
--D
> > Reported-by: Dan Carpenter <dan.carpen...@oracle.com>
> > Signed-off-by: Christoph Hellwig <h...@lst.de>
>
> Looks good,
> Reviewed-by: Darrick J. Wong <djw...@kernel.org>
>
> --D
>
> > ---
> > fs/iomap/buffered-io.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/iomap/buffered-io.c b/fs/iomap/buffered-io.c
> > index b1511255b4df8..ac040d607f4fe 100644
> > --- a/fs/iomap/buffered-io.c
> > +++ b/fs/iomap/buffered-io.c
> > @@ -883,7 +883,7 @@ static loff_t iomap_zero_iter(struct iomap_iter *iter,
> > bool *did_zero)
> >
> > do {
> > unsigned offset = offset_in_page(pos);
> > - size_t bytes = min_t(u64, PAGE_SIZE - offset, length);
> > + ssize_t bytes = min_t(u64, PAGE_SIZE - offset, length);
> > struct page *page;
> > int status;
> >
> > --
> > 2.30.2
> >
