On Wed, Jan 5, 2022 at 9:09 PM Vishal Verma <[email protected]> wrote: > > A recent fedpkg update wants --name instead of --module-name.
Ugh, how annoying. > > Signed-off-by: Vishal Verma <[email protected]> > --- > contrib/do_abidiff | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/contrib/do_abidiff b/contrib/do_abidiff > index 0bd7a16..e8c3a65 100755 > --- a/contrib/do_abidiff > +++ b/contrib/do_abidiff > @@ -29,7 +29,7 @@ build_rpm() > version="$(./git-version)" > release="f$(basename $(readlink -f /etc/mock/default.cfg) | cut -d- > -f2)" > git archive --format=tar --prefix="ndctl-${version}/" HEAD | gzip > > ndctl-${version}.tar.gz > - fedpkg --release $release --module-name ndctl mockbuild > + fedpkg --release $release --name=ndctl mockbuild Would it be worthwhile to document the version of the fedpkg that this script targets? Otherwise, looks good to me. Reviewed-by: Dan Williams <[email protected]> > [ "$?" -eq 0 ] || err "error building $ref" > mkdir -p release/rel_${ref}/ > cp results_ndctl/*/*/*.x86_64.rpm release/rel_${ref}/ > -- > 2.33.1 >
