From: Alison Schofield <[email protected]> When a cxl_cmd_new_*() function is executed the returned command pointer is always checked for NULL. Remove extraneous NULL checks later in the command validation path.
Coverity pointed these out as 'check_after_deref' issues. Signed-off-by: Alison Schofield <[email protected]> --- cxl/lib/libcxl.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/cxl/lib/libcxl.c b/cxl/lib/libcxl.c index daa2bbc5a299..f111d8681669 100644 --- a/cxl/lib/libcxl.c +++ b/cxl/lib/libcxl.c @@ -2283,8 +2283,6 @@ cmd_to_identify(struct cxl_cmd *cmd) if (cxl_cmd_validate_status(cmd, CXL_MEM_COMMAND_ID_IDENTIFY)) return NULL; - if (!cmd) - return NULL; return cmd->output_payload; } @@ -2429,8 +2427,6 @@ cmd_to_get_partition(struct cxl_cmd *cmd) if (cxl_cmd_validate_status(cmd, CXL_MEM_COMMAND_ID_GET_PARTITION_INFO)) return NULL; - if (!cmd) - return NULL; return cmd->output_payload; } base-commit: 3b5fb8b6428dfaab39bab58d67412427f514c1f4 -- 2.31.1
