Thanks for looking into this patch Vishal. "Verma, Vishal L" <[email protected]> writes:
> On Tue, 2022-03-15 at 21:56 +0530, Vaibhav Jain wrote: >> This trivial patch updates 'meson.build' files for daxctl, ndctl to >> remove >> explicit dependency on 'iniparser'. Instead util/meson.build is >> updated to add a >> dependency to 'iniparser' which than get tricked to daxctl, ndctl via > > s/tricked/trickled/ Addressed this in V2 of the patch. Thanks for pointing this out. > > Otherwise looks good to me. > >> 'util_dep' >> dependency. >> >> Signed-off-by: Vaibhav Jain <[email protected]> >> --- >> daxctl/meson.build | 1 - >> ndctl/meson.build | 1 - >> util/meson.build | 1 + >> 3 files changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/daxctl/meson.build b/daxctl/meson.build >> index ec2e2b648d40..8474d02f2c0d 100644 >> --- a/daxctl/meson.build >> +++ b/daxctl/meson.build >> @@ -15,7 +15,6 @@ daxctl_tool = executable('daxctl', >> dependencies : [ >> daxctl_dep, >> ndctl_dep, >> - iniparser, >> util_dep, >> uuid, >> kmod, >> diff --git a/ndctl/meson.build b/ndctl/meson.build >> index 6a3d0e5348c2..c7889af36084 100644 >> --- a/ndctl/meson.build >> +++ b/ndctl/meson.build >> @@ -27,7 +27,6 @@ deps = [ >> uuid, >> kmod, >> json, >> - iniparser, >> versiondep, >> ] >> >> diff --git a/util/meson.build b/util/meson.build >> index 784b27915649..695037a924b9 100644 >> --- a/util/meson.build >> +++ b/util/meson.build >> @@ -11,6 +11,7 @@ util = static_library('util', [ >> 'abspath.c', >> 'iomem.c', >> ], >> + dependencies: iniparser, >> include_directories : root_inc, >> ) >> util_dep = declare_dependency(link_with : util) >> >> base-commit: dd58d43458943d20ff063850670bf54a5242c9c5 > -- Cheers ~ Vaibhav
