On Tue, 2023-02-07 at 21:47 -0800, Dan Williams wrote: > Vishal Verma wrote: <..> > > > > @@ -853,6 +854,10 @@ struct json_object *util_cxl_region_to_json(struct > > cxl_region *region, > > json_object_object_add(jregion, "size", jobj); > > } > > > > + jobj = json_object_new_string(cxl_decoder_mode_name(mode)); > > + if (jobj) > > + json_object_object_add(jregion, "type", jobj); > > + > > I am thinking this should be gated by an: > > if (mode != CXL_DECODER_MODE_NONE) > > ...just to avoid saying "type : none" on older kernels where there is an > implied non-NONE type.
Yep makes sense, I'll add this. > > Otherwise looks good to me: > > Reviewed-by: Dan Williams <dan.j.willi...@intel.com>
