From: Alison Schofield <alison.schofi...@intel.com> Changes since v2: - Adjust line break in snprintf (Jonathan, Vishal) - Replace region|memdev context struct with optional func params (Vishal) - Include CXL Spec version and update to 3.1 references (Vishal) - Remove '_poison' descriptor from nested poison objects (Vishal) - Use existing UTIL_JSON_MEDIA_ERRORS flag (Vishal) - Replace lengthy if-else with switch-case (Vishal) - Remove needless fprintf on sysfs fail (Vishal) - Remove needless jobj inits to NULL (Vishal) - s/jmedia/jpoison everywhere (Vishal) - Replace hardcoded memdev w discovered memdev in unit test (Vishal) - Use test/common define $CXL_TEST_BUS (Vishal) - Reset rc=1 after setup in unit test (Vishal) - Add debugfs helpers in unit test (Vishal) - Syntax fixups in the unit test (Vishal) - A few minor cleanups in unit test. - Link to v2: https://lore.kernel.org/linux-cxl/cover.1696196382.git.alison.schofi...@intel.com/
Changes since v1: - Replace 'media-error' language with 'poison'. At v1 I was spec obsessed and following it's language strictly. Jonathan questioned it at the time, and I've come around to simply say poison, since that is the language we've all been using for the past year+. It also aligns with the inject-poison and clear-poison options that have been posted on this list. - Retrieve poison per region by iterating through the contributing memdevs. (The by region trigger was designed out of the driver implementation.) - Add the HPA and region info to both the by region and by memdev cxl list json. - Applied one review tag to the untouched pid patch. (Jonathan) - Link to v1: https://lore.kernel.org/nvdimm/cover.1668133294.git.alison.schofi...@intel.com/ Add the option to include a memory device poison list in cxl list json output. Examples appended below: by memdev, by region, by memdev and coincidentally in a region, and no poison found. Example: By memdev cxl list -m mem1 --poison -u { "memdev":"mem1", "pmem_size":"1024.00 MiB (1073.74 MB)", "ram_size":"1024.00 MiB (1073.74 MB)", "serial":"0x1", "numa_node":1, "host":"cxl_mem.1", "poison":{ "nr_records":4, "records":[ { "dpa":"0x40000000", "dpa_length":64, "source":"Injected", "flags":"" }, { "dpa":"0x40001000", "dpa_length":64, "source":"Injected", "flags":"" }, { "dpa":"0", "dpa_length":64, "source":"Injected", "flags":"" }, { "dpa":"0x600", "dpa_length":64, "source":"Injected", "flags":"" } ] } } Example: By region cxl list -r region5 --poison -u { "region":"region5", "resource":"0xf110000000", "size":"2.00 GiB (2.15 GB)", "type":"pmem", "interleave_ways":2, "interleave_granularity":4096, "decode_state":"commit", "poison":{ "nr_records":2, "records":[ { "memdev":"mem1", "region":"region5", "hpa":"0xf110001000", "dpa":"0x40000000", "dpa_length":64, "source":"Injected", "flags":"" }, { "memdev":"mem0", "region":"region5", "hpa":"0xf110000000", "dpa":"0x40000000", "dpa_length":64, "source":"Injected", "flags":"" } ] } } Example: By memdev and coincidentally in a region # cxl list -m mem0 --poison -u { "memdev":"mem0", "pmem_size":"1024.00 MiB (1073.74 MB)", "ram_size":"1024.00 MiB (1073.74 MB)", "serial":"0", "numa_node":0, "host":"cxl_mem.0", "poison":{ "nr_records":1, "records":[ { "region":"region5", "hpa":"0xf110000000", "dpa":"0x40000000", "dpa_length":64, "source":"Injected", "flags":"" } ] } } Example: No poison found cxl list -m mem9 --poison -u { "memdev":"mem9", "pmem_size":"1024.00 MiB (1073.74 MB)", "ram_size":"1024.00 MiB (1073.74 MB)", "serial":"0x9", "numa_node":1, "host":"cxl_mem.9", "poison":{ "nr_records":0 } } Alison Schofield (5): libcxl: add interfaces for GET_POISON_LIST mailbox commands cxl: add an optional pid check to event parsing cxl/list: collect and parse the poison list records cxl/list: add --poison option to cxl list cxl/test: add cxl-poison.sh unit test Documentation/cxl/cxl-list.txt | 64 +++++++++++ cxl/event_trace.c | 5 + cxl/event_trace.h | 1 + cxl/filter.h | 3 + cxl/json.c | 201 +++++++++++++++++++++++++++++++++ cxl/lib/libcxl.c | 47 ++++++++ cxl/lib/libcxl.sym | 6 + cxl/libcxl.h | 2 + cxl/list.c | 2 + test/cxl-poison.sh | 135 ++++++++++++++++++++++ test/meson.build | 2 + 11 files changed, 468 insertions(+) create mode 100644 test/cxl-poison.sh base-commit: a871e6153b11fe63780b37cdcb1eb347b296095c -- 2.37.3
