Re: [ndctl PATCH v2 2/2] daxctl: Remove unimplemented create-device options

[Alison Schofield]

On Fri, May 31, 2024 at 02:29:59PM +0800, Li Zhijian wrote:
> RECONFIG_OPTIONS and ZONE_OPTIONS are not implemented for create-device
> and they will be ignored by create-device. Remove them so that the usage
> message is identical to the manual.
> 
> Signed-off-by: Li Zhijian <lizhij...@fujitsu.com>

The net effect of this is a correction to the usage message.
I think that can fit in the commit msg with something like this:

daxctl: Remove unused options in create-device usage message

I'm not familiar with this style of patch 2 being a reply to patch 1.
Is there a reason this is not presented as a patchset?

Thanks,
Alison


> ---
> V2: make the usage match the manual because the usage is wrong.
> ---
>  daxctl/device.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/daxctl/device.c b/daxctl/device.c
> index ffabd6cf5707..781dc4007f83 100644
> --- a/daxctl/device.c
> +++ b/daxctl/device.c
> @@ -98,8 +98,6 @@ OPT_BOOLEAN('\0', "no-movable", &param.no_movable, \
>  static const struct option create_options[] = {
>       BASE_OPTIONS(),
>       CREATE_OPTIONS(),
> -     RECONFIG_OPTIONS(),
> -     ZONE_OPTIONS(),
>       OPT_END(),
>  };
>  
> -- 
> 2.29.2
> 
>