On 2/26/25 12:30, Zhijian Li (Fujitsu) wrote:
On 26/02/2025 14:02, Donet Tom wrote:
On 2/20/25 19:05, Jeff Moyer wrote:
diff --git a/ndctl/json.c b/ndctl/json.c
index 23bad7f..7646882 100644
--- a/ndctl/json.c
+++ b/ndctl/json.c
@@ -381,7 +381,7 @@ struct json_object *util_region_capabilities_to_json(struct
ndctl_region *region
struct ndctl_pfn *pfn = ndctl_region_get_pfn_seed(region);
struct ndctl_dax *dax = ndctl_region_get_dax_seed(region);
- if (!btt || !pfn || !dax)
+ if (!btt && !pfn && !dax)
return NULL;
jcaps = json_object_new_array();
Reviewed-by: Jeff Moyer <jmo...@redhat.com>
Thanks Jeff
Hi Alison
Should I send a v3 with Reviewed-by tag
Generally speaking, there is no need for you to do this.
A small tip might be helpful if you send a patch next time.
v1 -> v2:
Addressed the review comments from Jeff and Alison.
v1:
https://lore.kernel.org/all/20250219094049.5156-1-donet...@linux.ibm.com/
Commit messages that are not intended to appear in the upstream git tree
should be placed after the '---' marker. [0]
Thanks Zhijian. I will take care of this from now on.
Thanks
Donet
[0] https://docs.kernel.org/process/submitting-patches.html#commentary
Thanks
Zhijian
or will you take the patch with the tag?
Thanks
Donet
