From: Marc Herbert <marc.herb...@linux.intel.com> move err() function at the top so we can fail early. err() does not have any dependency so it can be first.
Signed-off-by: Marc Herbert <marc.herb...@linux.intel.com> --- test/common | 25 ++++++++++++++----------- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/test/common b/test/common index 75ff1a6e12be..74e74dd4fff9 100644 --- a/test/common +++ b/test/common @@ -1,6 +1,20 @@ # SPDX-License-Identifier: GPL-2.0 # Copyright (C) 2018, FUJITSU LIMITED. All rights reserved. +# err +# $1: line number which error detected +# $2: cleanup function (optional) +# + +test_basename=$(basename "$0") + +err() +{ + echo test/"$test_basename": failed at line "$1" + [ -n "$2" ] && "$2" + exit "$rc" +} + # Global variables # NDCTL @@ -53,17 +67,6 @@ E820_BUS="e820" # Functions -# err -# $1: line number which error detected -# $2: cleanup function (optional) -# -err() -{ - echo test/$(basename $0): failed at line $1 - [ -n "$2" ] && "$2" - exit $rc -} - reset() { $NDCTL disable-region -b $NFIT_TEST_BUS0 all -- 2.49.0