On Thu, Aug 14, 2025 at 03:17:15PM -0700, Marc Herbert wrote: snip > > If nothing else, the comment should be a bit more specific and mention > the relevant "nameref" or "indirection" keyword.
Done - used both keywords in a more verbose explanation in v2. snip > >>> + if [ "$expect_failures" = "false" ]; then > >> > >> if "$expect_failures"; then > > > > Is the existing pattern wrong or is that an ask for brevity? > > Yes, just for brevity and clarity. I mean you would not write "if > (some_bool == false)" in another language. Not important. Disconnect is I was thinking string compares, not bools. I changed this in v2 to use builtin true/false bash-isms Thanks for the reviews!
