Alison Schofield wrote:
> When the --media-errors option was added to cxl list it inadvertently
> changed the optional libtracefs requirement into a mandatory one.
> NDCTL versions 80,81,82 no longer build without libtracefs.
> 
> With this change, NDCTL builds with or without libtracefs.
> 
> Now, when libtracefs is not enabled, users will see:
>       $ cxl list -r region0 --media-errors
>       Error: unknown option `media-errors'

...but it is a known option that is documented. I.e. I would have
expected:


  $ cxl list -r region0 --media-errors
  Notice: --media-errors support disabled at build time.
  [
    {
      "region": "region...

Let the command continue because that would also match the behavior of:

  $ cxl list -vvv

...which does not fail when media errors can not be retrieved, and would
also make things like:

  $ cxl list -R --media-errors --health

...at least give some useful data and succeed rather than fail and
require the script to be re-written to drop the option.

Reply via email to