On 4/8/26 2:39 PM, Cheatham, Benjamin wrote:
> On 4/8/2026 3:32 PM, Terry Bowman wrote:
>> Current CXL error injection (EINJ) only supports Root Port protocol error
>> injection but a method to test all CXL devices is needed. This series
>> outlines methods to update both the kernel and the 'aer-inject' tool-without
>> relying on EINJ-to enable CXL RAS protocol error handling across all CXL
>> devices.
>>
>
> This functionality should probably be added to the inject-protocol-error
> subcommand
> instead of spread out across the directory as a bunch of scripts + patches.
> The command
> is only set up for protocol error injection, but I don't think it would be
> *too* hard
> to extend.
>
> I think the first thing you have to do is expand the accepted device types to
> include ports and
> memdevs instead of just dports. That should be simple enough, there are
> already helpers to find
> both based on sbdf, name, etc. Then, you'd need to change the interface used
> to inject the error
> based on device type (is it a root port? then use EINJ, otherwise use
> aer-inject). All that's
> left at that point is to actually call the aer-inject command with the
> correct options (and
> update the documentation/help messages).
>
> I would be happy to help with any of the above if you agree with the
> direction, just let me
> know!
Thanks for the Review Ben! Initially Dan and I asked Terry to just provide his
test scripts in the CXL CLI test/contrib directory as a place holder until we
can figure out how to integrate it. But if you have better ideas of how to
improve the usability, help is much appreciated!
>
> Thanks,
> Ben
