+ linuxppc-dev (for awareness, since I also faced the same issue on Power too, although this one is not related to PPC alone)
Muchun Song <[email protected]> writes: > Static pmem Device DAX namespaces reserve space for namespace metadata > before the user-visible data range, and may also include padding needed > to satisfy the Device DAX alignment. __dax_pmem_probe() adjusts the > dax_region range to start at the data range, but the dev_pagemap range > still starts at the beginning of the namespace. > > That is not valid for compound devmap mappings whose memmap is stored in > system RAM. Compound page initialization requires the start PFN to be > naturally aligned to the compound page size, because the head and tail > struct pages are initialized according to that geometry. If the pgmap > starts before the aligned data range, memmap_init_zone_device() can build > compound page metadata from an unaligned PFN. > > The resulting struct page layout is inconsistent with the Device DAX > mapping. A later mmap fault can then resolve the user-visible PFN through > invalid compound page metadata and hit a kernel panic while inserting the > DAX folio. > > Fix this by advancing the pgmap start to the aligned Device DAX data > range for non-altmap compound mappings. Leave base-page namespaces > unchanged, and leave the altmap path unchanged because > memmap_init_zone_device() already skips the altmap reservation itself. > > Fixes: 14606001efb4 ("device-dax: compound devmap support") > Cc: <[email protected]> > Reported-by: Ritesh Harjani (IBM) <[email protected]> Thanks Muchun for fixing this. With this patch I am no more seeing the following crash (tested on both Power and x86 kvm) Feel free to add for this patch. Tested-by: Ritesh Harjani (IBM) <[email protected]> [ 4.675578] page dumped because: VM_BUG_ON_PAGE(!zone_spans_pfn(page_zone(page), pfn)) [ 4.675613] ------------[ cut here ]------------ [ 4.675615] kernel BUG at mm/page_alloc.c:373! [ 4.675626] Oops: invalid opcode: 0000 [#1] SMP DEBUG_PAGEALLOC PTI [ 4.678213] CPU: 1 UID: 0 PID: 1 Comm: swapper/0 Not tainted 7.3.0-rc5-xfstests-01065-g45f4c1453cbe #33 PREEMPT(full) [ 4.678213] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.16.3-0-ga6ed6b701f0a-prebuilt.qemu.org 04/01/2014 [ 4.678213] RIP: 0010:__set_pfnblock_flags_mask.constprop.0+0xef/0x110 <...> [ 4.678213] Call Trace: [ 4.678213] <TASK> [ 4.678213] pageblock_migratetype_init_range.constprop.0+0x50/0x90 [ 4.678213] memmap_init_zone_device+0x2fb/0x380 [ 4.678213] pagemap_range+0x272/0x590 [ 4.678213] memremap_pages+0x125/0x210 [ 4.678213] ? lockdep_hardirqs_on+0x7d/0x100 [ 4.678213] devm_memremap_pages+0x21/0x70 [ 4.678213] dev_dax_probe+0x1db/0x300 [ 4.678213] dax_bus_probe+0x6f/0xa0 [ 4.678213] call_driver_probe+0x24/0xf0 [ 4.678213] really_probe+0xb6/0x310 [ 4.678213] ? __pfx___device_attach_driver+0x10/0x10 [ 4.678213] __driver_probe_device+0x87/0x190 [ 4.678213] ? __pfx___device_attach_driver+0x10/0x10 [ 4.678213] driver_probe_device+0x1f/0x90 [ 4.678213] __device_attach_driver+0x89/0x130 [ 4.678213] bus_for_each_drv+0x86/0xe0 [ 4.678213] __device_attach+0xb6/0x1d0 [ 4.678213] device_initial_probe+0x40/0x60 [ 4.678213] bus_probe_device+0x3d/0xa0 [ 4.678213] device_add+0x4f0/0x6c0 [ 4.678213] __devm_create_dev_dax+0x18b/0x3f0 [ 4.678213] devm_create_dev_dax+0x21/0x40 [ 4.678213] __dax_pmem_probe+0x1c3/0x200 [ 4.678213] dax_pmem_probe+0xe/0x20 [ 4.678213] nvdimm_bus_probe+0x89/0x250 [ 4.678213] call_driver_probe+0x24/0xf0 [ 4.678213] really_probe+0xb6/0x310 [ 4.678213] ? __pfx___driver_attach+0x10/0x10 [ 4.678213] __driver_probe_device+0x87/0x190 [ 4.678213] ? __pfx___driver_attach+0x10/0x10 [ 4.678213] driver_probe_device+0x1f/0x90 [ 4.678213] __driver_attach+0xd7/0x200 [ 4.678213] bus_for_each_dev+0x79/0xc0 [ 4.678213] bus_add_driver+0x127/0x250 [ 4.678213] driver_register+0x59/0x100 [ 4.678213] ? __pfx_dax_pmem_init+0x10/0x10 [ 4.678213] do_one_initcall+0x59/0x3a0 [ 4.678213] do_initcalls+0xdd/0x1b0 [ 4.678213] kernel_init_freeable+0x16f/0x2b0 [ 4.678213] ? __pfx_kernel_init+0x10/0x10 [ 4.678213] kernel_init+0x1f/0x1d0 [ 4.678213] ret_from_fork+0x244/0x280 [ 4.678213] ? __pfx_kernel_init+0x10/0x10 [ 4.678213] ret_from_fork_asm+0x1a/0x30 [ 4.678213] </TASK> > Closes: https://lore.kernel.org/r/[email protected] > Assisted-by: LLM > Signed-off-by: Muchun Song <[email protected]> > --- > drivers/dax/pmem.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/dax/pmem.c b/drivers/dax/pmem.c > index bee93066a849..d3a9b85107b0 100644 > --- a/drivers/dax/pmem.c > +++ b/drivers/dax/pmem.c > @@ -51,6 +51,13 @@ static struct dev_dax *__dax_pmem_probe(struct device *dev) > /* adjust the dax_region range to the start of data */ > range = pgmap.range; > range.start += offset; > + /* > + * When the memmap is stored in RAM, exclude metadata and alignment > + * padding from compound page initialization. Otherwise, the pgmap > + * may start before the naturally aligned Device DAX data range. > + */ > + if (!pgmap_altmap(&pgmap) && le32_to_cpu(pfn_sb->align) > PAGE_SIZE) BTW, this check "le32_to_cpu(pfn_sb->align) > PAGE_SIZE" - Is that needed here? I am trying to understand this better - so that I can add more such testcases internally. For the test I mentioned earlier [1] - even w/o that align check, the test passes. [1]: https://lore.kernel.org/r/[email protected] -ritesh > + pgmap.range.start = range.start; > dax_region = alloc_dax_region(dev, region_id, &range, > nd_region->target_node, le32_to_cpu(pfn_sb->align), > IORESOURCE_DAX_STATIC); > > base-commit: 0fcb05b72344f40806cbe810de8872f1698bf053 > -- > 2.54.0
