On Thu, Oct 22, 2026 at 12:49:11PM -0400, Gregory Price (Meta) wrote: > On 2026-10-21 19:34 -0700, Alison Schofield wrote: > > On Fri, Oct 16, 2026 at 05:42:48PM -0400, Gregory Price (Meta) wrote: > > > From: Gregory Price <[email protected]> > > > > > > Repeat the online/offline pair to cover onlining from 'unplugged', and > > > check that offline-memory unplugs an already offline device. After each > > > step, check block counts and, where present, daxX.Y/state and the > > > 'hotplug_state' reported by 'daxctl list'. > > > > Hi Greg, > > > > Please change how the tests handle the absence of the new sysfs attribute. > > If a test expects the new interface, a missing attribute should cause > > the test to fail, with a clear error message. We have had problems in > > the past with tests silently not executing letting defects go undetected. > > > > ack > > > Note that we don't require backward compatibility for the unit tests. > > The utilities must continue working with older kernels, but tests for new > > functionality should fail loudly when that functionality is missing. > > (I'm aware that not all tests follow that guideline, and they need fixing.) > > > > this is slightly confusing, but noted. I would have expected the tests > to test backward compatibility. But ack.
SKIP if kernel version doesn't support. You'll see this pattern in other unit tests: check_min_kver "7.3" || do_skip "kernel may lack ...." After that, fail if kernel version should support yet the attribute is missing. -- Alison snip
