Hi Jim, On Wed, May 06, 2009 at 05:09:16PM -0400, James Carlson wrote: > I have a pile of small fixes and enhancements to DHCP and NWAM, and > I'd like to get code review comments from you folks on them. The > changes are several but not substantial. > > The external webrev is here: > > http://cr.opensolaris.org/~carlsonj/webrev-4783123/
I've looked over this (I'll confess I wasn't too careful looking over the contract-related bits in dhcpagent_util.c, though); it looks good. -renee > An equivalent internal one is here: > > http://zhadum.east/ws/carlsonj/4783123-fix/webrev/ > > And an internal workspace with cscope is here: > > /net/zhadum.east/export/ws/carlsonj/4783123-fix/ > > The "main" problems being fixed are CRs 6835298 and 6834140 (the > latter of which was just discussed on nwam-discuss). Because I'm > touching /etc/default/dhcpagent, I went around to find a handful of > simple fixes to toss in along with these changes. That accounts for > CRs 4783123 and 6667011. The remainder are there because I'm touching > dhcpagent and nwamd. > > I've put each one of these fixes through unit testing on a Tecra > laptop with "wpi0" and "e1000g0" interfaces. I have full SPARC and > x86 nightly builds running now, and an updated nwamd has been sent to > the submitter of CR 6834140 for verification. > > I still have to: > > - run the DHCP client test suite; results should be unchanged from > Nevada. > > - update the CRs with the diffs, complete the PSARC case, file the > documentation CRs, and file the RTI. > > My target is build 116 (closes May 26th), and if I could get either > comments or requests for more time (either on this list or to me > personally) within a week's time, that would be appreciated. Feel > free to forward this notice to anyone you think might be a good > reviewer for the changes. > > Thanks! > > -- > James Carlson, Solaris Networking <james.d.carlson at sun.com> > Sun Microsystems / 35 Network Drive 71.232W Vox +1 781 442 2084 > MS UBUR02-212 / Burlington MA 01803-2757 42.496N Fax +1 781 442 1677 > _______________________________________________ > nwam-dev mailing list > nwam-dev at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/nwam-dev
