> > I have a pile of small fixes and enhancements to DHCP and NWAM, and
> > I'd like to get code review comments from you folks on them. The
> > changes are several but not substantial.
> >
> > The external webrev is here:
> >
> > http://cr.opensolaris.org/~carlsonj/webrev-4783123/
> >
> > An equivalent internal one is here:
> >
> > http://zhadum.east/ws/carlsonj/4783123-fix/webrev/
Sorry for the delay. I didn't look at the NWAM changes. Things look
good; just some minor comments:
states.c:
* 461-464: Seems like it'd be simpler to just check if dsm_ack !=
NULL; is there a reason that's inappropriate?
agent.c:
* 522: Comment saying "we should report failure" seems odd given
the subsequent sentence.
defaults.c:
* 62: Indenting for "NULL" seems a bit off.
dhcpagent_ipc.c:
* 289: Seems like DHCP_IPC_WAIT_FOREVER would be more appropriate.
dhcpagent_util.c:
* 86-108: Appears to be lifted from zoneadmd.c; perhaps an RFE is
in-order for a utility function. Then again, we should probably
be using SMF for the DHCP client anyway.
* 174: Comment here seems odd; was "child to finish" meant?
* 155-158: I'm a bit confused by this. Why not just put the
contract_latest(&ct) call directly in the `default' arm of
the swtich statement?
--
meem
