>> code review requested for the following bugs: >> >> 8782 still some lingering upgrade problems >> 8775 too many cooks spoil the vboxnet interface >> 8763 missing/incomplete validation functions for property values >> >> http://zhadum.east.sun.com/export/ws/am223141/checkout-area/nwam1-fixes/webrev/ >> > Kinda strange that valid_uint64 is really for a 63 bit uint ;) > > getprefixlen actually mods it input buffer which is unclear from its name > > valid_host_v4 should validate a prefix (cidr netmask) at the end > > valid_host_v6 should validate a prefix > changed getprefixlen() to reveal what it actually does - validate prefixes. Rather than having that function modify its input, valid_host_v{4,6}() modifies it. webrev updated.
Anurag
