looks good. minor nit: 203-204 - "clear all objects" not only ncus.
Anurag Renee Danson Sommerfeld wrote: > On Thu, Oct 08, 2009 at 10:13:53AM -0700, Renee Danson Sommerfeld wrote: > >> On Wed, Oct 07, 2009 at 04:53:00PM -0700, Michael Hunter wrote: >> >>> On Wed, 07 Oct 2009 16:00:58 -0700 >>> Renee Danson Sommerfeld <renee.sommerfeld at sun.com> wrote: >>> >>> >>>> ...for these two bugs: >>>> >>>> 11770 nwamd dumps core if SIGHUP comes in too early >>>> http://defect.opensolaris.org/bz/show_bug.cgi?id=11770 >>>> >>>> 11804 yet another reason periodic checks might not happen >>>> http://defect.opensolaris.org/bz/show_bug.cgi?id=11804 >>>> >>>> Webrev is at http://jurassic.eng/~okie/webrev/index.html >>>> >>> Per our discussion in my office I think you should block SIGHUP earlier. >>> >> Okay, I'll rework this and put up a new webrev later today. >> > > An updated webrev with a reworked fix for 11770 is here: > > http://jurassic.eng/~okie/webrev.sigs/index.html > > Please let me know what you think. > > -renee > _______________________________________________ > nwam-dev mailing list > nwam-dev at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/nwam-dev >
