Alan,

various things, tell me if you agree or not.  One of us can fix the issues:

* when DL_NOTE_LINK_UP/DOWN event is received, and 
nwamd_ncu_handle_link_state_event() is called, it should not change the 
state as it does now.  Rather, nwamd_ncp_check_priority_group() should 
be called with the link's priority-group.

* current_ncu_priority_group should be initially set to UINT64_MAXINT 
and also on refresh so that nwamd_ncp_check_priority_group() can proceed 
above.

* from what I understand, wa.activate should be B_FALSE in 
nwamd_ncp_deactivate_priority_group().

* link_is_up() function doesn't seem to be working correctly, right?

Anurag


Alan.Maguire at Sun.COM wrote:
> Author: Alan Maguire <Alan.Maguire at Sun.COM>
> Repository: /hg/nwam/nwam1
> Latest revision: 3412c327fe1e8d59643b2667c9626a23e68ef998
> Total changesets: 1
> Log message:
> various nwamd fixes: segvs in ncu init, state transitions to offline* when 
> connected need to be fixed to maintain online state, need to read in 
> ncu_wait_time prop and use it to dictate priority group switch interval
>
> Files:
>       update: usr/src/cmd/cmd-inet/lib/nwamd/events.h
>       update: usr/src/cmd/cmd-inet/lib/nwamd/main.c
>       update: usr/src/cmd/cmd-inet/lib/nwamd/ncp.c
>       update: usr/src/cmd/cmd-inet/lib/nwamd/ncp.h
>       update: usr/src/cmd/cmd-inet/lib/nwamd/ncu.c
>       update: usr/src/cmd/cmd-inet/lib/nwamd/ncu_phys.c
>       update: usr/src/cmd/cmd-inet/lib/nwamd/util.h
>       update: usr/src/cmd/cmd-inet/usr.sbin/nwamadm/nwamadm.c
> _______________________________________________
> nwam-dev mailing list
> nwam-dev at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/nwam-dev
>   

Reply via email to