Anurag S. Maskey wrote: > Alan, > > various things, tell me if you agree or not. One of us can fix the > issues: > > * when DL_NOTE_LINK_UP/DOWN event is received, and > nwamd_ncu_handle_link_state_event() is called, it should not change > the state as it does now. Rather, nwamd_ncp_check_priority_group() > should be called with the link's priority-group. Not sure that's the right approach. I think the right answer is for manaul NCUs to go online on getting a link up. For prioritized, we should ignore the link up event if the priority of the link is > (less prioritized) the current priority, otherwise we go online and then the object state change handler (nwamd_ncu_handle_state_event()) should check the priority group associated with the link going online or offline. > > * current_ncu_priority_group should be initially set to UINT64_MAXINT > and also on refresh so that nwamd_ncp_check_priority_group() can > proceed above. > hmm, not sure. The find_next_priority_group stuff works on the value >= the current, so if we start with 0 we should be fine. > * from what I understand, wa.activate should be B_FALSE in > nwamd_ncp_deactivate_priority_group(). > good catch! > * link_is_up() function doesn't seem to be working correctly, right? > no, and I don't think it's needed - I reintroduced it because I didn't realize that the dlpi_enabnotify() will trigger initial link state events for us. Thanks!
Alan
