http://defect.opensolaris.org/bz/show_bug.cgi?id=10311
amaguire <alan.maguire at sun.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |alan.maguire at sun.com
Status|CLOSED |REOPENED
Resolution|FIXINSOURCE |
--- Comment #3 from amaguire <alan.maguire at sun.com> 2009-07-29 00:23:13 ---
(In reply to comment #2)
> I think nwamd_configure_interface_addresses() needs to be called after
> nwamd_transition_ip_state(). But I'm not convinced that ya'all intended this
> to be done so literally (maybe as part of the refresh condition check
> instead?).
>
> nwamd_transition_ip_state(oldncu, ncu);
> nwamd_ncu_free(oldncu);
> + /* pickup new addresses */
> + nwamd_configure_interface_addresses(ncu);
I don't think this is the right place for this. The transition process is
designed to determine which addresses the pre-refreshed and refreshed IP NCU
share, and if these shared addresses are configured, it marks them as such in
the new NCU configuration. Applying the addresses at this point seems wrong
since the activation conditions for the IP NCU may not be satisfied. The right
thing to do here is to transition the state properly given the underlying link
state - if it is up, and if the IP NCU is enabled, we should re-initialize,
going back to the INIT aux state. This will drive interface config.
I think we need to enqueue a link check event on the condition that no other
link check is enqueued. This will drive the link back online, and as a
consequence we'll move the IP NCU back to an online state, configuring the
interface addresses into the bargain.
--
Configure bugmail: http://defect.opensolaris.org/bz/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
