a few thoughts on some cleanup we could do in the daemon:
- dns_updates.[ch] can be removed - we still use get_dhcpinfo_data(),
so I'd suggest we move that into ncu_ip.c
- we've got a nice split between generic code (objects.[ch],
events.[ch]), event sources (dlpi_events.c, sysevents.c etc),
and object-specific event handlers (enm.c, loc.c etc), but there's a few
inconsistencies I think we should fix:
- ncu_datalink.c should become ncu_phys.c, since it
handles physical datalinks. We can add ncu_iptun.c,
ncu_vnic.c etc later for other link classes.
- I think it'd make sense to split ncu_events.c out into
ncu_ip.c and ncu_phys.c since they do the ip and physical
event handling.
- some of the vestiges of the phase 0 codebase (defines.h,
structures.h, variables.h) still exist. These should be moved
into the appropriate .h files.
All this would leave us with a daemon with the following
source files, grouped by category:
event sources:
dlpi_events.c
routing_events.c
sysevent_events.c
object-specific event handlers:
enm.c
known_wlans.c
loc.c
ncp.c
ncu_ip.c
ncu_phys.c
legacy config upgrade
llp.c
generic code:
objects.c
events.c
conditions.c
logging.c
util.c
nwam door requests:
door_if.c
(and of course main.c).
Thoughts?
Alan
