On Fri, 17 Apr 2009 11:04:42 +0100
Alan Maguire <Alan.Maguire at Sun.COM> wrote:
> a few thoughts on some cleanup we could do in the daemon:
>
> - dns_updates.[ch] can be removed - we still use get_dhcpinfo_data(),
> so I'd suggest we move that into ncu_ip.c
>
> - we've got a nice split between generic code (objects.[ch],
> events.[ch]), event sources (dlpi_events.c, sysevents.c etc),
> and object-specific event handlers (enm.c, loc.c etc), but there's a few
> inconsistencies I think we should fix:
>
> - ncu_datalink.c should become ncu_phys.c, since it
> handles physical datalinks. We can add ncu_iptun.c,
> ncu_vnic.c etc later for other link classes.
> - I think it'd make sense to split ncu_events.c out into
> ncu_ip.c and ncu_phys.c since they do the ip and physical
> event handling.
>
> - some of the vestiges of the phase 0 codebase (defines.h,
> structures.h, variables.h) still exist. These should be moved
> into the appropriate .h files.
>
> All this would leave us with a daemon with the following
> source files, grouped by category:
>
> event sources:
> dlpi_events.c
> routing_events.c
> sysevent_events.c
>
> object-specific event handlers:
> enm.c
> known_wlans.c
> loc.c
> ncp.c
> ncu_ip.c
> ncu_phys.c
>
> legacy config upgrade
> llp.c
>
> generic code:
> objects.c
> events.c
> conditions.c
> logging.c
> util.c
>
> nwam door requests:
> door_if.c
>
> (and of course main.c).
>
> Thoughts?
All good ideas. I've got some of this in a tree.
I'm also thinking about moving lookup_{count,...} into the lib. That
way they can all be there but if we don't use one we won't end up with
a lint warning.
I'll push what I have tomorrow.
These warnings still exist as of now:
"/builds/mph/nwam1_work/usr/src/cmd/cmd-inet/lib/nwamd/events.c", line 473:
warning: name used but not defined: backtrace in events.c(473)
(E_NAME_USED_NOT_DEF2)
"/builds/mph/nwam1_work/usr/src/cmd/cmd-inet/lib/nwamd/events.c", line 329:
warning: name defined but never used: nwamd_event_init_if_action in
events.c(329) (E_NAME_DEF_NOT_USED2)
"/builds/mph/nwam1_work/usr/src/cmd/cmd-inet/lib/nwamd/ncu_datalink.c", line
138: warning: name defined but never used: visited_wlan_list in
ncu_datalink.c(138) (E_NAME_DEF_NOT_USED2)
"/builds/mph/nwam1_work/usr/src/cmd/cmd-inet/lib/nwamd/ncu_datalink.c", line
144: warning: name defined but never used: wireless_scan_level in
ncu_datalink.c(144) (E_NAME_DEF_NOT_USED2)
"/builds/mph/nwam1_work/usr/src/cmd/cmd-inet/lib/nwamd/ncu_datalink.c", line
888: warning: name defined but never used: nwamd_test_wlan_connection_thread in
ncu_datalink.c(888) (E_NAME_DEF_NOT_USED2)
"/builds/mph/nwam1_work/usr/src/cmd/cmd-inet/lib/nwamd/ncu_ip.c", line 78:
warning: name defined but never used: display in ncu_ip.c(78)
(E_NAME_DEF_NOT_USED2)
"/builds/mph/nwam1_work/usr/src/cmd/cmd-inet/lib/nwamd/objects.c", line 162:
warning: name defined but never used: nwamd_object_lists_fini in objects.c(162)
(E_NAME_DEF_NOT_USED2)
"/builds/mph/nwam1_work/usr/src/cmd/cmd-inet/lib/nwamd/objects.c", line 326:
warning: name defined but never used: nwamd_object_fini in objects.c(326)
(E_NAME_DEF_NOT_USED2)
"/builds/mph/nwam1_work/usr/src/cmd/cmd-inet/lib/nwamd/util.c", line 104:
warning: name defined but never used: get_ifflags in util.c(104)
(E_NAME_DEF_NOT_USED2)
"/builds/mph/nwam1_work/usr/src/cmd/cmd-inet/lib/nwamd/util.c", line 511:
warning: name defined but never used: lookup_count_property in util.c(511)
(E_NAME_DEF_NOT_USED2)
I'll get rid of a few more before I push.
mph
>
> Alan
> _______________________________________________
> nwam-dev mailing list
> nwam-dev at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/nwam-dev
