On Wed, 23 Sep 2009 23:21:06 -0400 "Anurag S. Maskey" <Anurag.Maskey at Sun.COM> wrote:
> Code review for > > 11103 - 'ncu:ip' should not go into 'online' at first, instead of > 'offline*' > > http://zhadum.east/export/ws/am223141/temp/nwam1-work/webrev/ > > The fix examines the NCU state when DHCP times out and only changes to > offline*, timed out if the NCU is not in the online state. Also, an > interface with 0.0.0.0 is disregarded when checking if an interface is > managed by DHCP. > > The webrev also changes the syslog level of message when state change > events are enqueued. > > Finally, I noticed that sometimes multiple LINK UP events are received > and processed by nwamd. I added code to ignore LINK UP state event if > the link NCU is already in an online state. ncu_ip.c:529 Add code here to filter out IPv6 link local addresses (which IPv6 DHCP sets IFF_DHCP on when its trying to get a stateful address) and/or file a bug to do this. ncu_ip.c:1278-1300 What are we trying to fix and why here? We don't know that there isn't something in the event stream between what is currently being processed and when this will be processed that doesn't need to see this ncu up. mph > > Thanks, > Anurag > > > _______________________________________________ > nwam-dev mailing list > nwam-dev at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/nwam-dev
