Both Alan and Michael's comments addressed. Michael Hunter wrote: >> http://zhadum.east/export/ws/am223141/temp/nwam1-work/webrev/ >> > ncu_ip.c:529 Add code here to filter out IPv6 link local addresses > (which IPv6 DHCP sets IFF_DHCP on when its trying to get a stateful > address) and/or file a bug to do this. > Added IN6_IS_ADDR_LINKLOCAL() to skip link-local address. Also, I updated the comments.
> ncu_ip.c:1278-1300 What are we trying to fix and why here? We don't > know that there isn't something in the event stream between what is > currently being processed and when this will be processed that doesn't > need to see this ncu up. > Like Alan said in his comments, if the ncu is already online when DHCP times out, it means that there is already an address configured for this NCU. So, we shouldn't be changing to offline*, timed out state. Alan Maguire wrote: > ncu_ip.c: nit here, and maybe it's just me but would it > be better to get rid of the "goto done_with_interface" > stuff and just do "icfg_close(ifh);continue;" at line > 518, 528 and for the logic where we break > out of the loop, just do something like: accepted. no more gotos. I've updated the webrev. Anurag
