On Fri, 25 Sep 2009 15:41:41 -0400 "Anurag S. Maskey" <Anurag.Maskey at Sun.COM> wrote:
> Anurag S. Maskey wrote: > > Code review for > > > > 11103 - 'ncu:ip' should not go into 'online' at first, instead of > > 'offline*' > > > > http://zhadum.east/export/ws/am223141/temp/nwam1-work/webrev/ > > > webrev updated. > > When DHCP times out, it doesn't check the state of the NCU, it enqueues > the DHCP_TIMED_OUT state change event. In > nwamd_ncu_handle_state_event(), the current state is checked to make > sure that the NCU is not online. If online, then the state change event > to DHCP_TIMED_OUT is ignored. This should alleviate the problem raised > about what's already waiting in the event queue. > Sounds good to me. > Other parts of the daemon that check the current state of the NCU before > enqueuing a state change event should go here. I wonder if we can organize states such that a more general statement of /* treating the states as an orderable set */ if (object->nwamd_object_state >= new_aux_state) { ... return; } or maybe /* encoding what state overrides another in a boolean array */ if (!overrides[object->nwamd_object_state][new_aux_state]) { ... return; } In any case a thought for later consideration. mph > > Anurag > > _______________________________________________ > nwam-dev mailing list > nwam-dev at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/nwam-dev
