Michael Hunter wrote: > "Anurag S. Maskey" <Anurag.Maskey at Sun.COM> wrote: > >>> Code review for >>> >>> 11103 - 'ncu:ip' should not go into 'online' at first, instead of >>> 'offline*' >>> >>> http://zhadum.east/export/ws/am223141/temp/nwam1-work/webrev/ >>> > I wonder if we can organize states such that a more general statement of > > /* treating the states as an orderable set */ > if (object->nwamd_object_state >= new_aux_state) { > ... > return; > } > > or maybe > > /* encoding what state overrides another in a boolean array */ > if (!overrides[object->nwamd_object_state][new_aux_state]) { > ... > return; > } > > In any case a thought for later consideration. > Definitely an enhancement here is possible and necessary. The ordering may not be entirely numerical, so the array should be the way to go.
Anurag
