Anurag S. Maskey wrote: > >> http://zhadum.east.sun.com/export/ws/amaguire/nwam1-cr/webrev/ > > enm.c:217 - does argv[0] need to have CTRUN? It's passed to > nwamd_start_childv() in line 240. > I think it's needed - for posix_spawnp(3C) we need to pass in the path to the executable and it needs to be argv[0] since we're essentially assembling the argv array for the spawned program. > enm.c:219 - If CTRUN is argv[0], then this should be argv[1] (you're > checking if strtok_r() returned NULL, right?). you're right - thanks for catching this. Fixed. > Otherwise, ok > > The rest looks good. > Thanks for the review!
Alan
