Michael Hunter wrote: > On Thu, 22 Oct 2009 02:26:09 -0700 > Michael Hunter <michael.hunter at sun.com> wrote: > > [...] > >>> http://zhadum.east.sun.com/export/ws/amaguire/nwam1-cr/webrev/ >>> >>> >>> ...has been respun to include enm.c fixes. Thanks! >>> >> Looks good. >> > > nit: Since we are always reducing the size of the block I don't think > we need to check for a NULL return from realloc(). > > good point, I've fixed that. I just noticed I was doing something dumb in the for() loop - I was setting argv[i] in the initialization part of the loop (called once) rather than in the guard, that's fixed.
I've also added a few other bugfixes - if anyone has the cycles to look, I'd really appreciate it (I've tested these changes via nwamcfg etc). Webrev respun http://zhadum.east.sun.com/export/ws/amaguire/nwam1-cr/webrev/ Thanks! Alan
