Thanks Michael and Anurag for the reviews. On Mon, Oct 19, 2009 at 09:18:14AM -0400, Anurag S. Maskey wrote: > >>> http://jurassic.eng/~okie/webrev.legacy-sigs/ >>> >>> This includes my fix for >>> >>> 12015 Legacy location should not be advertised >>> http://defect.opensolaris.org/bz/show_bug.cgi?id=12015 >>> >>> As well as an additional change that I missed in my fix for >>> >>> 11770 nwamd dumps core if SIGHUP comes in too early >>> http://defect.opensolaris.org/bz/show_bug.cgi?id=11770 >>> >>> Comments welcome! >>> >> >> libnwam_loc.c:305 This strdup()s memory for locname so you need to free >> it.
ACCEPT > Also, how about using the constant NWAM_LOC_NAME_LEGACY already defined > in libnwam.h for strcmp(). ACCEPT Webrev is updated with both changes: http://jurassic.eng/~okie/webrev.legacy-sigs/index.html -renee
