Renee Danson Sommerfeld wrote: > On Mon, Oct 19, 2009 at 08:36:01AM -0700, Michael Hunter wrote: > >> On Mon, 19 Oct 2009 08:33:05 -0700 >> Renee Danson Sommerfeld <renee.sommerfeld at sun.com> wrote: >> >> [...] >> >>> Webrev is updated with both changes: >>> >>> http://jurassic.eng/~okie/webrev.legacy-sigs/index.html >>> >> Looks good! >> > > Oops, no. I was only free()'ing the string in the failure > case; it needs to be freed on success (no match). Also, in > the failure case, it should not be freed if we failed because > we failed to get the name. > > Webrev is updated once more: > > http://jurassic.eng/~okie/webrev.legacy-sigs/index.html > is good.
Anurag
