On Tue, Nov 03, 2009 at 09:47:50AM -0800, Renee Danson Sommerfeld wrote:
> On Tue, Nov 03, 2009 at 05:01:45PM +0000, Alan Maguire wrote:
> > hi folks
> >
> > review needed for:
> >
> > 12437 For link properties, only set physaddr when necessary and reorder
> > mtu/autopush/physaddr setting
> >
> > webrev at
> >
> > http://zhadum.east/export/ws/amaguire/nwam1-bugs/webrev
>
> This looks good; thanks!
Actually, I take that back. One small concern:
207-08: hwaddr is not a printable string, it's a number. You probably
want to use addr here.
This is not new, it was in the code you moved; and it appears to have
been mostly copied from similar usage of _link_aton() in ifconfig.c.
But it should be fixed!
Thanks,
renee
> > We think this will ameliorate the intermittent nge issues
> > Renee was seeing, since the device resets emnating from
> > physical address setting will be limited to times when we
> > actually need to change the MAC address, as they should be.
> > Also, I was seeing very occasional EAGAIN errors on
> > attempting to set the MTU linkprop, I suspect these could
> > result from the device not being ready after reset (resulting
> > from setting the physical address).
> >
> > Alan
> > _______________________________________________
> > nwam-dev mailing list
> > nwam-dev at opensolaris.org
> > http://mail.opensolaris.org/mailman/listinfo/nwam-dev
> _______________________________________________
> nwam-dev mailing list
> nwam-dev at opensolaris.org
> http://mail.opensolaris.org/mailman/listinfo/nwam-dev
