On Tue, Nov 03, 2009 at 07:21:10PM +0000, Alan Maguire wrote: > Renee Danson Sommerfeld wrote: >> On Tue, Nov 03, 2009 at 09:47:50AM -0800, Renee Danson Sommerfeld wrote: >> >>> On Tue, Nov 03, 2009 at 05:01:45PM +0000, Alan Maguire wrote: >>> >>>> hi folks >>>> >>>> review needed for: >>>> >>>> 12437 For link properties, only set physaddr when necessary and >>>> reorder mtu/autopush/physaddr setting >>>> >>>> webrev at >>>> >>>> http://zhadum.east/export/ws/amaguire/nwam1-bugs/webrev >>>> >>> This looks good; thanks! >>> >> >> Actually, I take that back. One small concern: >> >> 207-08: hwaddr is not a printable string, it's a number. You probably >> want to use addr here. >> >> > good catch, I've fixed this now. Thanks for reviewing!
Excellent, thanks. I think this is good to go. Thanks for doing it! -renee
