Renee Danson Sommerfeld wrote: > On Mon, Nov 30, 2009 at 02:02:52AM -0800, Michael Hunter wrote: > >> /net/coupe.eng/builds/mph/nwam1-cr-fixes/webrev >> > > Note: I'm assuming webrev path is actually > > /net/coupe.eng/builds/mph/nwam1_cr_fixes/webrev/ > > I looked through the changes and noticed some things. Then, I saw that Renee has already mentioned those things. Having one event queue really simplifies the implementation.
Anurag > (underscores instead of hyphens) > > > events.c > 489: s/schedule/scheduled/ > > 493: As none of the current set of callers require nanosecond granularity > (0 is passed for delta_ns in all cases), I think this parameter > should be removed and a value of 0 assumed. > > 528: Why is this here? Seems like this parameter should just be removed, > as this odd line is the only reference to it now. > > 548: This needs to be on two lines. > > -renee > _______________________________________________ > nwam-dev mailing list > nwam-dev at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/nwam-dev >
