On Thu, 03 Dec 2009 16:56:56 +0000 Alan Maguire <Alan.Maguire at Sun.COM> wrote:
> Alan Maguire wrote: > > I've got a few reviews to do for others today, but I thought > > it'd be no harm to get this out there too: > > > > http://zhadum.east.sun.com/export/ws/amaguire/nwam1-rfes/webrev/ > > > > Thanks! > > > ...and here's the webrev for 12353 also: > > http://zhadum.east.sun.com/export/ws/amaguire/nwam1-cr/webrev/ <rant> conditions.c:144-146 This code burst bugs me. We make sure that we compare a consistent active ncp name. But we don't keep the semantic consistency of the enclosing function. Further computation using that result is dated as soon as pthread_mutex_unlock() is called. I'm not sure if this is an object and it is spread throughout the code, but it bugs me. </rant> There isn't much to do for this in the context of this bug. These changes look good. Michael > > Alan > _______________________________________________ > nwam-dev mailing list > nwam-dev at opensolaris.org > http://mail.opensolaris.org/mailman/listinfo/nwam-dev
