Alan Maguire wrote: > I've got a few reviews to do for others today, but I thought > it'd be no harm to get this out there too: > > http://zhadum.east.sun.com/export/ws/amaguire/nwam1-rfes/webrev/ nwamadm.c: 595, 598, 644, 648 must free(realname) before calling die() or die_nwamerr().
I think libnwam_values.c:nwam_value_string_get_uint64() must do a strcasecmp() since that function is used to determine value for the class (in nwamadm.c:399-403). If "nwamadm list -c PHYS" works, then there is no need. nwamcfg.c: 1923, 1925 must check if realname is not NULL and use name if NULL (similar to line 1669) nwamcfg.c: *_listprop() these were rewritten when I reworked the "-a" option. Oops. It is going to be quite a merge headache for you. sorry. But I think the changes after that are not difficult. The changes replace all the *_listprop() functions with one listprop() function that takes the object_type. I think you'll just have to pass "realname" in the case of "/* handle is not NULL, get the object's name */" section. The overall flow of the code is similar to what each of the *_listprop() function did. The changes in libnwam look good. Thanks, Anurag
