Anurag Maskey wrote: > code review requested for: > > 11321 Network Autoconf profile needs more granularity > http://defect.opensolaris.org/bz/show_bug.cgi?id=11321 > > The webrev is at: > > http://zhadum.east/export/ws/am223141/temp/nwam1-work/webrev/ > > The design for this RFE was described in the following mail: > > http://mail.opensolaris.org/pipermail/nwam-dev/2009-December/005411.html > > Basically, the changeset adds solaris.network.autoconf.{select,wlan} > authorizations and splits Network Autoconf into Network Autoconf Admin > and Network Autoconf User. > > solaris.network.autoconf.select is required to enable/disable profiles > by nwamadm. solaris.network.autoconf.wlan is required to do any action > related to Known WLANs (create, modify, destroy, scan-wifi, select-wifi, > etc). The other libnwam objects require solaris.network.autoconf.write > to be created, modified, or destroyed.
libnwam_known_wlan.c: 438: existing typo: s/NO_COLLSION_CHECK/NO_COLLISION_CHECK/ -- libnwam_loc.c: 1108: Since you're bothering to check return values now and nwam_walk_locs() returns nwam_error_t, is there a reason you're not checking that return value also? -- Otherwise this approach of splitting out the things a user would need vs. an admin looks reasonable. An aside: does the NWAM test suite do anything to test authorizations and privileges? -Paul
