>> http://zhadum.east/export/ws/am223141/temp/nwam1-work/webrev/ >> > libnwam_known_wlan.c: > 438: existing typo: s/NO_COLLSION_CHECK/NO_COLLISION_CHECK/ > fixed.
> libnwam_loc.c: > 1108: Since you're bothering to check return values now and > nwam_walk_locs() returns nwam_error_t, is there a reason you're not > checking that return value also? > I noticed that the nwam_walk_locs() can fail even before the walk of the objects have started. cb_ret is not set in this case and defaulted to NWAM_SUCCESS set before its pointer was passed to the walk. cb_ret is only set when the callback function returns an error or the walk successfully completes. I have redone the code so that the return value from the walk is set to cb_ret if the walk stops before looping through the objects. webrev has been updated. > Otherwise this approach of splitting out the things a user would need > vs. an admin looks reasonable. > > An aside: does the NWAM test suite do anything to test authorizations > and privileges? > The test suite has tests that check actions performed by users with different authorizations. The new authorizations must be added to the test suite and also existing tests fixed. Anurag
